perf(ai): Avoid a few std::vector copies when passing ai paths to functions #1895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caball009
reviewed
Nov 24, 2025
xezon
reviewed
Nov 25, 2025
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
Did you check that the passed vector is never used after it is consumed?
xezon
added
Minor
Author
Looking at call sites, they all pass local vectors (exitPath, path) that are not used after the function call. They go out of scope immediately, so this is safe, right? |
|
Yes, when the std::vector contents are not used anymore after they are now consumed by the functions then this is safe. |
xezon
reviewed
Nov 25, 2025
xezon
reviewed
Nov 29, 2025
Generals/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp
Outdated
Show resolved
Hide resolved
xezon
reviewed
Nov 29, 2025
Generals/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp
Outdated
Show resolved
Hide resolved
xezon
reviewed
Nov 30, 2025
bobtista
force-pushed
the
bobtista/move-vector-instead-of-copy
branch
from
e97db76 to
8c112de
Compare
xezon
reviewed
Dec 16, 2025
Generals/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp
Outdated
Show resolved
Hide resolved
|
Still needs work here. |
…hange parameter to reference
bobtista
force-pushed
the
bobtista/move-vector-instead-of-copy
branch
from
e9b7e5c to
5965d08
Compare
xezon
approved these changes
Jan 2, 2026
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
Looks good in principle. 2 more suggestions.
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp
Outdated
Show resolved
Hide resolved
xezon
changed the title
xezon
approved these changes
Jan 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors path-following functions to use move when transferring
std::vector<Coord3D>ownershipChanges:
aiFollowExitProductionPathandaiFollowPathinline functions to accept non-const vector pointers and usestd::moveAIStateMachine::setGoalPathto move the vector instead of copyingprivateFollowPathanddoQuickExitsignatures to support move semantics